These points can be used for shoulder pain from any origin. You do need to find the underlying cause - impingement syndrome, other forms of injury, lifestyle causes such as postural habits or repetitive motions, etc.
As with any other acupuncture treatment, figure out what the affected channel is before you start treating. Add other points intelligently to treat the dysfunction.
Gallbladder channel pain: San Zhong Bladder channel pain: Qi Hu
Shen Guan Fantastic point to treat shoulder pain. Like one of the best.
Bloodlet at Lung 5
Option 2 - three needle treatment